Break up ValueNode.cs so each Value has it's own file #2713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitek-karas
approved these changes
Mar 29, 2022
sbomer
approved these changes
Mar 29, 2022
sbomer
reviewed
Mar 31, 2022
Member
sbomer
left a comment
sbomer
left a comment
There was a problem hiding this comment.
One more thing I noticed: would you mind moving ValueNodeList and ValueBasicBlockPair out of the shared namespace? They should just live in Mono.Linker.Dataflow I think.
agocke
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
…2713) * Break up ValueNode.cs so each Value has it's own file * Update ValueNode.cs namespace Commit migrated from dotnet/linker@987a86e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy and pasted each of the class definitions from ValueNode.cs to their own file to make navigation easier.