Skip to content

Update array data flow test #2704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 23, 2022
Merged

Conversation

jtschuster
Copy link
Member

@jtschuster jtschuster commented Mar 23, 2022

It looks like there was a mistake on the tests for array tracking. Passing an array element as a ref parameter should reset that element, but not others. Previously it expected that it would not reset the known index.

@jtschuster jtschuster requested a review from marek-safar as a code owner March 23, 2022 22:26
Copy link
Member

@sbomer sbomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@jtschuster jtschuster merged commit 04c49c9 into dotnet:main Mar 23, 2022
agocke pushed a commit to dotnet/runtime that referenced this pull request Nov 16, 2022
* Fix array dataflow test for passing ref to element

Commit migrated from dotnet/linker@04c49c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants