Skip to content

Parsing update for native header files with feature switch #2044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 21, 2021

Conversation

LakshanF
Copy link
Contributor

Added support to parse native header files that have the feature switch macro defined. Should be a no-op if the feature switch macro is not defined in a header file

@LakshanF LakshanF requested review from sbomer and vitek-karas May 18, 2021 23:08
Copy link
Member

@vitek-karas vitek-karas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests. (There is an existing test already, so adding to it or adding a new one should not be that hard)

@LakshanF LakshanF requested a review from marek-safar as a code owner May 19, 2021 23:30
Copy link
Member

@vitek-karas vitek-karas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@sbomer
Copy link
Member

sbomer commented May 20, 2021

In case you don't know - you can run lint.cmd/lint.sh to fix formatting issues

@LakshanF LakshanF merged commit 4526d38 into dotnet:main May 21, 2021
@LakshanF LakshanF deleted the ComRootParsing branch May 21, 2021 20:00
agocke pushed a commit to dotnet/runtime that referenced this pull request Nov 16, 2022
Parsing update for native header files with feature switch

Commit migrated from dotnet/linker@4526d38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants