PR feedback

src/linker/Linker.Steps/UnreachableBlocksOptimizer.cs

@@ -212,18 +212,16 @@ static bool IsComparisonAlwaysTrue (OpCode opCode, int left, int right)
 				return null;
 
 			var analyzer = new ConstantExpressionMethodAnalyzer (this);
-			if (analyzer.Analyze (callee, callStack)) {
-				return new MethodResult (analyzer.Result, analyzer.SideEffectFreeResult && !HasSideEffects (method));
-			}
+			if (analyzer.Analyze (callee, callStack))
+				return new MethodResult (analyzer.Result, analyzer.SideEffectFreeResult);
 
 			return null;
-
-			static bool HasSideEffects (MethodDefinition method)
-			{
-				return !method.DeclaringType.IsBeforeFieldInit;
-			}
 		}
 
+		static bool HasSideEffects (MethodDefinition method)
+		{
+			return !method.DeclaringType.IsBeforeFieldInit;
+		}
 
 		//
 		// Return expression with a value when method implementation can be
@@ -1399,6 +1397,8 @@ public bool Analyze (in CalleePayload callee, Stack<MethodDefinition> callStack)
 				Instruction? linstr;
 				object? left, right, operand;
 
+				SideEffectFreeResult = !HasSideEffects (method);
+
 				//
 				// We could implement a full-blown interpreter here but for now, it handles
 				// cases used in runtime libraries