[jnienv-gen] Generate a header file for the native functions #809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonpryor
reviewed
Feb 24, 2021
|
Current failure in Java.Interop (Mac - .NET Core) is because mono crashed. Restarted the tests. |
grendello
force-pushed
the
gen-ji-native-header
branch
from
365b7e9 to
260e61b
Compare
In addition to generating a .c file, generate a .h one with declarations of all the functions defined in the .c file. The header will be used by the NET6 build of Xamarin.Android's native runtime. Additionally, make it possible to not export symbols by defining the `JI_NO_VISIBILITY` preprocessor macro. This will also be used by the NET6 build of Xamarin.Android native runtime (which will no longer need to make the symbols visible for `p/invoke` to work)
grendello
force-pushed
the
gen-ji-native-header
branch
from
260e61b to
82d1675
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to generating a .c file, generate a .h one with declarations
of all the functions defined in the .c file. The header will be used by
the NET6 build of Xamarin.Android's native runtime.
Additionally, make it possible to not export symbols by defining the
JI_NO_VISIBILITYpreprocessor macro. This will also be used by theNET6 build of Xamarin.Android native runtime (which will no longer need
to make the symbols visible for
p/invoketo work)