Add ActivatePeer to JniValueManager #784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To allow different implementation of creating the activator/constructor methods on desktop and mobile. The goal is to avoid using SLE in mobile version, to improve linking.
|
The |
jonpryor
reviewed
Jan 21, 2021
jonpryor
reviewed
Jan 21, 2021
jonpryor
reviewed
Jan 21, 2021
| @@ -28,3 +28,10 @@ | |||
| "814f144e5d817efc4c6502cc012df310783348304e3ae38573c6d658c234025821fda87a0be8a0" + | |||
| "d504df564e2c93b2b878925f42503e9d54dfef9f9586d9e6f38a305769587b1de01f6c0410328b" + | |||
| "2c9733db")] | |||
| [assembly: InternalsVisibleTo ( | |||
There was a problem hiding this comment.
I'm torn between accepting this, or just copying the JniLocationException type into Java.Runtime.Environment.dll to avoid the InternalsVisibleTo… :-/
And pass `ConstructorInfo` instead of types information.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/android#5400
To allow different implementation of creating the activator/constructor
methods on desktop and mobile.
The goal is to avoid using SLE in mobile version, to improve linking.