[generator] fix enum managed return type. #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6d161a2 caused (either regressed or exposed) another issue that generator didn't resole the return values for enums to be EnumSymbol which gives explicit cast from int to enum for the output expressions. This returns managed_type (which should be enum name) for enumified return value (IsEnumified = true).
Contributor
|
Any chance we could add a test which hits this codepath in e.g. https://github.com/xamarin/java.interop/tree/master/tools/generator/Tests-Core or https://github.com/xamarin/java.interop/tree/master/tools/generator/Tests/expected? |
Contributor
|
"The perfect is the enemy of the good." Tests can be done after fixing monodroid. We still should get tests. |
Contributor
Author
|
Once you finish porting existing monodroid tests to these public repos (namely codegen / mcw / bxc9446) works as a test case. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6d161a2 caused (either regressed or exposed) another issue that generator
didn't resole the return values for enums to be EnumSymbol which gives
explicit cast from int to enum for the output expressions.
This returns managed_type (which should be enum name) for enumified return
value (IsEnumified = true).