Skip to content

[generator] Revert change to use auto-properties in EventArgs classes. #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2020

Conversation

jpobst
Copy link
Contributor

@jpobst jpobst commented Oct 13, 2020

In #726, properties in generated EventArgs classes were changed from regular properties to use auto-properties:

From:

int param1;
public int Param1 {
    get { return param1; }
}

To:

public int Param1 { get; }

However this is technically a breaking change, since users could have hand written code that references the backing field. Although the usage is likely rare, we have decided to revert the auto-property change for compatibility reasons.

@jpobst jpobst marked this pull request as ready for review October 13, 2020 15:19
@jonpryor jonpryor merged commit b991bb8 into master Oct 13, 2020
@jonpryor jonpryor deleted the revert-auto-props branch October 13, 2020 20:04
@jpobst jpobst added this to the 11.1 (16.9 / 8.9) milestone Oct 13, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants