Skip to content

Remove <Imports> now covered by Directory.Build.props. #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2020

Conversation

jpobst
Copy link
Contributor

@jpobst jpobst commented Mar 19, 2020

In #605, we created a Directory.Build.props file which automatically imports several things for all projects. The projects that are still manually importing these same files are creating duplicate warnings like:

tests\Java.Interop-Tests\Java.Interop-Tests.csproj(33,3): 
Warning MSB4011: "d:\a\1\s\bin\BuildRelease\JdkInfo.props" cannot be imported again. It was already imported at "d:\a\1\s\Directory.Build.props (13,3)". This is most likely a build authoring error. This subsequent import will be ignored. 

This doesn't fix the jnienv-gen.csproj warnings, they will be fixed when the project is converted to sdk-style.

@jpobst jpobst force-pushed the build-props-warnings branch from 8d52299 to e2f2300 Compare March 19, 2020 19:43
@jpobst jpobst marked this pull request as ready for review March 19, 2020 19:56
@jonpryor jonpryor merged commit e070ce3 into master Mar 19, 2020
@jonpryor jonpryor deleted the build-props-warnings branch March 19, 2020 20:12
@jpobst jpobst added this to the d16-7 milestone Apr 10, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants