[generator] Fix case not renaming property setter parameter to "value" #566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eter to "value". [#565]
jpobst
changed the title
jonpryor
pushed a commit
that referenced
this pull request
Feb 19, 2020
Fixes: #565 In a case with generics, we were not renaming the property setter parameter to `value`, which meant it could be left as `p0`, which is not valid C#: // This method is explicitly implemented as a member of an instantiated Google.Android.Material.DatePicker.IDateSelector global::Java.Lang.Object global::Google.Android.Material.DatePicker.IDateSelector.Selection { // Metadata.xml XPath method reference: path="/api/package[@name='com.google.android.material.datepicker']/interface[@name='DateSelector']/method[@name='getSelection' and count(parameter)=0]" [Register ("getSelection", "()Ljava/lang/Object;", "GetGetSelectionHandler:Google.Android.Material.DatePicker.IDateSelectorInvoker, Xamarin.Google.Android.Material")] get { return Selection; } // Metadata.xml XPath method reference: path="/api/package[@name='com.google.android.material.datepicker']/interface[@name='DateSelector']/method[@name='setSelection' and count(parameter)=1 and parameter[1][@type='S']]" [Register ("setSelection", "(Ljava/lang/Object;)V", "GetSetSelection_Ljava_lang_Object_Handler:Google.Android.Material.DatePicker.IDateSelectorInvoker, Xamarin.Google.Android.Material")] set { Selection = global::Java.Interop.JavaObjectExtensions.JavaCast<global::Java.Lang.Long>(p0); } } This would result in a C# error: error CS0103: The name 'p0' does not exist in the current context. The fix is to temporarily override the property's setter's parameter name to `value` so that we emit compilable C# code: set { Selection = JavaObjectExtensions.JavaCast<Long>(value); }
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #565
In a case with generics, we were not renaming the property setter parameter to
valuewhich meant it was left asp0which is not valid C#.Before:
Now: