[generator] Make _members private to reduce warnings building binding projects. #522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the answer is "yes": https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=3257127&view=logs&jobId=460c7805-8cd4-5a32-0896-edade521f618&j=460c7805-8cd4-5a32-0896-edade521f618&t=82b96727-a3ab-5884-7261-30bf5b9ca088 No significant errors reported. |
jpobst
changed the title
jonpryor
pushed a commit
that referenced
this pull request
Dec 10, 2019
Because the `JniPeerMembers _members` field is exposed via the
`IJavaPeerable.JniPeerMembers` interface property, we no longer need
the field to be `internal`, which means we no longer need to worry
about when to add `new`.
Makes the `_members` field visibility `private`, which reduces the
number of warnings that occur when building a binding project.
static readonly JniPeerMembers _members = new JniPeerMembers ("xamarin/test/SomeObject", typeof (SomeObject));
public override global::Java.Interop.JniPeerMembers JniPeerMembers {
get { return _members; }
}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the
JniPeerMembers _membersfield is exposed via theIJavaPeerable.JniPeerMembersinterface property, we no longer need the field to beinternal, which means we no longer need to worry about when to addnew. This PR makes the_membersfieldprivatewhich reduces the number of warnings that occur when building a binding project.