-
Notifications
You must be signed in to change notification settings - Fork 59
Convert Test projects to SDK style projects. #517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<!-- | ||
Our testing infrastructure depends on a known location for: | ||
- NUnit.Console | ||
- csc.exe | ||
--> | ||
<configuration> | ||
<config> | ||
<add key="globalPackagesFolder" value="$\..\packages" /> | ||
</config> | ||
</configuration> |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,7 +5,7 @@ | |
<_TopDir>$(MSBuildThisFileDirectory)..\..</_TopDir> | ||
<_Runtime Condition=" '$(RUNTIME)' != '' ">$(RUNTIME)</_Runtime> | ||
<_Runtime Condition=" '$(RUNTIME)' == '' And '$(OS)' != 'Windows_NT' ">mono --debug</_Runtime> | ||
<_NUnit>$(_Runtime) packages\NUnit.ConsoleRunner.3.9.0\tools\nunit3-console.exe</_NUnit> | ||
<_NUnit>$(_Runtime) packages\nunit.consolerunner\3.9.0\tools\nunit3-console.exe</_NUnit> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. And adds the slash... |
||
<_Run Condition=" '$(RUN)' != '' ">--run="$(RUN)"</_Run> | ||
</PropertyGroup> | ||
<Import | ||
|
@@ -33,7 +33,7 @@ | |
<SetEnvironmentVariable Name="JAVA_INTEROP_LREF_LOG" Value="bin\Test$(Configuration)\l-%(_TestAssembly.Filename).txt" /> | ||
<SetEnvironmentVariable Name="JI_JVM_PATH" Value="$(JdkJvmPath)" /> | ||
<Exec | ||
Command="$(_NUnit) $(NUNIT_EXTRA) %(_TestAssembly.Identity) $(_Run) --result="TestResult-%(Filename).xml;format=nunit2" --output="bin\Test$(Configuration)\TestOutput-%(Filename).txt"" | ||
Command="$(_NUnit) $(NUNIT_EXTRA) %(_TestAssembly.Identity) $(_Run) --result="TestResult-%(Filename).xml" --output="bin\Test$(Configuration)\TestOutput-%(Filename).txt"" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why is There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure why, but when I left it in there, the CI NUnit choked on it and said it wasn't a valid format. Removing it seems to work, the tests are still picked up for the test tab: I think now it defaults to |
||
WorkingDirectory="$(_TopDir)" | ||
ContinueOnError="ErrorAndContinue" | ||
/> | ||
|
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is
$
in$\..\packages
? I can't easily find any mention of this behavior. (Environment variables are supported.)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently it is "local to this NuGet.Config", since you could have several configs getting inherited.
https://stackoverflow.com/questions/18376313/setting-up-a-common-nuget-packages-folder-for-all-solutions-when-some-projects-a