[Java.Interop.Tools.Generator] Improve ExtractApiLevel() resiliency #1365
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: f07b538
Context: https://github.com/jpobst/BindingStudio
While using jpobst/BindingStudio to enumify API-36.1, it would crash:
The cause of the crash is that the
api-36.1.xmlfile it was processing had//@merge.SourceFileattributes with the value:Notice the
-Workin the value. This was used byExtractApiLevel()to try to find numbers after the-, butWwas after the-, not numbers.This didn't previously matter because f07b538 noted:
However, when jpobst/BindingStudio is used,
src/Mono.Android/metadatais not used, and//@merge.SourceFileis instead used.Improve
ParseApiLevel()to check for anapi-prefix before looking for trailing numeric data.