Skip to content

[Java.Interop.Tools.JavaCallableWrappers] fix net8.0 targeting in XA #1197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 23, 2024
Merged

[Java.Interop.Tools.JavaCallableWrappers] fix net8.0 targeting in XA #1197

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
04533d3
[Java.Interop.Tools.JavaCallableWrappers] don't build net8.0 in XA
jonathanpeppers Feb 22, 2024
28ed806
Just remove AppendTargetFrameworkToOutputPath=false
jonathanpeppers Feb 22, 2024
ea3c48a
Update Java.Interop.Tools.JavaCallableWrappers.csproj
jonathanpeppers Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions src/Java.Interop.Tools.JavaCallableWrappers/Java.Interop.Tools.JavaCallableWrappers.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<XAConfigPath>..\..\bin\Build$(Configuration)\XAConfig.props</XAConfigPath>
</PropertyGroup>
<Import Condition="Exists ('$(XAConfigPath)')" Project="$(XAConfigPath)" />

<PropertyGroup>
<TargetFrameworks>netstandard2.0;$(DotNetTargetFramework)</TargetFrameworks>
<AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>
<LangVersion>11.0</LangVersion>
<Nullable>enable</Nullable>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
Expand All @@ -19,7 +13,8 @@

<Import Project="..\..\TargetFrameworkDependentValues.props" />

<PropertyGroup>
<!-- Only use $(ToolOutputFullPath) for netstandard2.0 -->
<PropertyGroup Condition=" '$(TargetFramework)' == 'netstandard2.0' ">
<OutputPath>$(ToolOutputFullPath)</OutputPath>
</PropertyGroup>
Comment on lines -22 to 19
Copy link
Member Author

@jonathanpeppers jonathanpeppers Feb 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think what I ended up with is simple enough. This prevents us from putting the net8.0 library in $(ToolOutputFullPath).

The build error is gone in dotnet/android#8751, but we still have some runtime test failures.


Expand Down