[Java.Interop] restore IL2035 suppression
#1195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c6e3893 introduced build warning(s) in Android projects: external/Java.Interop/src/Java.Interop/Java.Interop/JniRuntime.JniMarshalMemberBuilder.cs(33,4): warning IL2035: Java.Interop.JniRuntime.SetMarshalMemberBuilder(JniRuntime.CreationOptions): Unresolved assembly 'Java.Interop.Export' in 'DynamicDependencyAttribute'. external/Java.Interop/src/Java.Interop/Java.Interop/JniRuntime.JniMarshalMemberBuilder.cs(33,4): warning IL2035: Java.Interop.JniRuntime.SetMarshalMemberBuilder(JniRuntime.CreationOptions): Unresolved assembly 'Java.Interop.Export' in 'DynamicDependencyAttribute'. external/Java.Interop/src/Java.Interop/Java.Interop/JniRuntime.JniMarshalMemberBuilder.cs(33,4): warning IL2035: Java.Interop.JniRuntime.SetMarshalMemberBuilder(JniRuntime.CreationOptions): Unresolved assembly 'Java.Interop.Export' in 'DynamicDependencyAttribute'. external/Java.Interop/src/Java.Interop/Java.Interop/JniRuntime.JniMarshalMemberBuilder.cs(33,4): warning IL2035: Java.Interop.JniRuntime.SetMarshalMemberBuilder(JniRuntime.CreationOptions): Unresolved assembly 'Java.Interop.Export' in 'DynamicDependencyAttribute'. One of these appear per-RID. Partially revert c6e3893 to restore one suppression that was removed.
jonpryor
pushed a commit
to dotnet/android
that referenced
this pull request
Feb 21, 2024
Changes: dotnet/java-interop@7d1e705...ae65609 * dotnet/java-interop@ae656097: [Java.Interop] restore `IL2035` suppression (dotnet/java-interop#1195) * dotnet/java-interop@c6e38933: [Java.Interop] use `Type.GetType()` to find `MarshalMemberBuilder` (dotnet/java-interop#1193) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c6e3893 introduced build warning(s) in Android projects:
One of these appear per-RID.
Partially revert c6e3893 to restore one suppression that was removed.