[Xamarin.Android.Tools.Bytecode-Tests] Fix BuildClasses #1013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `BuildClasses` target runs on every rebuild: % dotnet build … Build succeeded. "…/Java.Interop/Java.Interop.sln" (default target) (1:2) -> "…/Java.Interop/tests/Xamarin.Android.Tools.Bytecode-Tests/Xamarin.Android.Tools.Bytecode-Tests.csproj" (default target) (16:14) -> "…/Java.Interop/tests/Xamarin.Android.Tools.Bytecode-Tests/Xamarin.Android.Tools.Bytecode-Tests.csproj" (Build target) (16:15) -> (BuildClasses target) -> EXEC : warning : [options] bootstrap class path not set in conjunction with -source 8 […/Java.Interop/tests/Xamarin.Android.Tools.Bytecode-Tests/Xamarin.Android.Tools.Bytecode-Tests.csproj] "…/Java.Interop/Java.Interop.sln" (default target) (1:2) -> "…/Java.Interop/tests/Xamarin.Android.Tools.Bytecode-Tests/Xamarin.Android.Tools.Bytecode-Tests.csproj" (default target) (16:14) -> "…/Java.Interop/tests/Xamarin.Android.Tools.Bytecode-Tests/Xamarin.Android.Tools.Bytecode-Tests.csproj" (Build target) (16:16) -> EXEC : warning : [options] bootstrap class path not set in conjunction with -source 8 […/Java.Interop/tests/Xamarin.Android.Tools.Bytecode-Tests/Xamarin.Android.Tools.Bytecode-Tests.csproj] "…/Java.Interop/Java.Interop.sln" (default target) (1:2) -> "…/Java.Interop/tests/Xamarin.Android.Tools.Bytecode-Tests/Xamarin.Android.Tools.Bytecode-Tests.csproj" (default target) (16:14) -> "…/Java.Interop/tests/Xamarin.Android.Tools.Bytecode-Tests/Xamarin.Android.Tools.Bytecode-Tests.csproj" (Build target) (16:15) -> EXEC : warning : [options] bootstrap class path not set in conjunction with -source 8 […/Java.Interop/tests/Xamarin.Android.Tools.Bytecode-Tests/Xamarin.Android.Tools.Bytecode-Tests.csproj] "…/Java.Interop/Java.Interop.sln" (default target) (1:2) -> "…/Java.Interop/tests/Xamarin.Android.Tools.Bytecode-Tests/Xamarin.Android.Tools.Bytecode-Tests.csproj" (default target) (16:14) -> "…/Java.Interop/tests/Xamarin.Android.Tools.Bytecode-Tests/Xamarin.Android.Tools.Bytecode-Tests.csproj" (Build target) (16:16) -> EXEC : warning : [options] bootstrap class path not set in conjunction with -source 8 […/Java.Interop/tests/Xamarin.Android.Tools.Bytecode-Tests/Xamarin.Android.Tools.Bytecode-Tests.csproj] 4 Warning(s) 0 Error(s) % dotnet build # same as above; EXEC warnings from `BuildClasses` target % dotnet build # ad infinitum The cause for the warnings -- and the repetitive `BuildClasses` target execution -- is that the `@(_BuildClassOutputs)` item group is wrong; from the Dignostic build log: Target "BuildClasses: (TargetId:301)" in file "…/Java.Interop/tests/Xamarin.Android.Tools.Bytecode-Tests/Xamarin.Android.Tools.Bytecode-Tests.targets" from project "…/Java.Interop/tests/Xamarin.Android.Tools.Bytecode-Tests/Xamarin.Android.Tools.Bytecode-Tests.csproj" (target "BeforeCompile" depends on it): Building target "BuildClasses" completely. Output file "obj//Debug-net7.0/classes/Collection.class" does not exist. `obj/Debug-net7.0/classes/Collection.class` doesn't exist because it will *never* exist; the file created is *actually* `obj/Debug-net7.0/classes/java/util/Collection.class`. Note the "missing" `java/util` in the path. The cause of the missing `java/util` is that `@(_BuildClassOutputs)` uses `%(RecursiveDir)`, which only expands `**` wildcards, while `Collection.java` comes from: <TestJarNoParameters Include="java/java/util/Collection.java" /> Note the *lack* of `**`. Consequently, `%(RecursiveDir)` expanded as the empty string, which is why `java/util` was "lost". Fix this by introducing wildcards: <TestJarNoParameters Include="java/**/Collection.java" /> This fixes the repetitive `BuildClasses` execution: % dotnet build … EXEC : warning : [options] bootstrap class path not set in conjunction with -source 8 […/Java.Interop/tests/Xamarin.Android.Tools.Bytecode-Tests/Xamarin.Android.Tools.Bytecode-Tests.csproj] % dotnet build % no `EXEC : warning` message
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
BuildClassestarget runs on every rebuild:The cause for the warnings -- and the repetitive
BuildClassestargetexecution -- is that the
@(_BuildClassOutputs)item group is wrong;from the Dignostic build log:
obj/Debug-net7.0/classes/Collection.classdoesn't exist because itwill never exist; the file created is actually
obj/Debug-net7.0/classes/java/util/Collection.class.Note the "missing"
java/utilin the path.The cause of the missing
java/utilis that@(_BuildClassOutputs)uses
%(RecursiveDir), which only expands**wildcards, whileCollection.javacomes from:Note the lack of
**. Consequently,%(RecursiveDir)expanded asthe empty string, which is why
java/utilwas "lost".Fix this by introducing wildcards:
This fixes the repetitive
BuildClassesexecution: