Fix a possible crash when disposing ADS1115 device#2345
Merged
Conversation
dotnet-policy-service
Bot
added
the
area-device-bindings
Ellerbach
reviewed
Aug 20, 2024
pgrawehr
force-pushed
the
SomeMinorFixes
branch
from
dc21769 to
bf3c7d0
Compare
Ellerbach
approved these changes
Aug 23, 2024
Ellerbach
left a comment
Ellerbach
left a comment
Member
There was a problem hiding this comment.
Looks good. Thanks a lot for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case a communication error happens during dispose, the driver would crash.
Microsoft Reviewers: Open in CodeFlow