Fixing the Segmentation Fault in libgpiod V1 #2321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ellerbach
approved these changes
Jun 4, 2024
Member
Ellerbach
left a comment
Ellerbach
left a comment
There was a problem hiding this comment.
Looks good to me! Nice fix :-)
pgrawehr
approved these changes
Jun 4, 2024
Contributor
pgrawehr
left a comment
pgrawehr
left a comment
There was a problem hiding this comment.
We should have thought of this much earlier...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2313
This PR fixes the Segmentation Fault occuring when a wrong gpioChip is passed to the
libgpioddriver.In a Raspberry PI this is typically
0whichi is the default but on other boards there may be the need to specify a different number or even more than one (different I/Os are mapped on different chips).The problem was related to the
SafeHandlebeing non-null but invalid, therefore any following PInvoke to the nativelibgpiodlibrary resulted in the fault.After the change, the application calling the driver with a wrong
gpioChipreceive this exception message which can be handled in acatchstatement.The
libgpiodV2 manages thegpioChipdifferently and it should already ok.Microsoft Reviewers: Open in CodeFlow