Fix access violation issue in libgpiod v1 driver #2311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The handle is "owned" by the chip and is freed with that one. Freeing them in the wrong order causes an access violation
krwq
reviewed
May 9, 2024
src/System.Device.Gpio/System/Device/Gpio/Drivers/Libgpiod/LibGpiodDriver.cs
Outdated
Show resolved
Hide resolved
krwq
reviewed
May 9, 2024
joperezr
reviewed
May 9, 2024
joperezr
reviewed
May 16, 2024
src/System.Device.Gpio/Interop/Unix/libgpiod/V1/SafeLineHandle.cs
Outdated
Show resolved
Hide resolved
joperezr
reviewed
May 16, 2024
joperezr
reviewed
May 16, 2024
joperezr
reviewed
May 16, 2024
| <Right>lib/net6.0-windows10.0.17763/System.Device.Gpio.dll</Right> | ||
| </Suppression> | ||
| <Suppression> | ||
| <DiagnosticId>CP0002</DiagnosticId> |
Member
There was a problem hiding this comment.
I wouldn't expect this to show up as we should have the finalizer in both places. Can you please check why this is needed?
Contributor
Author
There was a problem hiding this comment.
I have no clue, but looks like a bug of the tool to me. We have added a finalizer, so why should there be a warning that it's now missing? I can't see why this would be a breaking change, anyway.
Contributor
Author
There was a problem hiding this comment.
I verified the generated IL. The finalize method is also present in the netstandard2.0 assembly.
Member
|
/azp run dotnet.iot |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@joperezr I unfortunately have no idea why we get that report about the missing finalizer. It is there in all places. |
krwq
approved these changes
Jun 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1849
After the cause is finally verified, this removes the SafeHandle base class from SafeLineHandle and changes it to a normal class. The line(s) are always disposed together with their chips, and thus do not need to be explicitly disposed. Lines (individual pins) must not be disposed after the chip is disposed.
This also adds various tests to make sure exceptions are thrown when attempting to use disposed drivers.
Microsoft Reviewers: Open in CodeFlow