Compiler multi threading support#2240
Merged
Merged
Conversation
The original implementation works just fine
Causes wrong temperature readings
…poses This code from the System library implements the number formatting. Following the code makes it a lot easier to debug EE errors (such as missing sign extensions)
This reverts commit ff17f55.
But seems to require proper try/catch/finally support, otherwise files are not closed.
By first only checking the name, method comparison is significantly faster (up to 10 times)
Was crashing because some array types are unexpectedly assignable to each other.
Seems to work now
Currently only one new command: --stop
…iThreading # Conflicts: # src/devices/Arduino/FirmataDevice.cs # tools/ArduinoCsCompiler/tests/FirmataIlExecutorTests.cs
pgrawehr
force-pushed
the
Compiler_MultiThreading
branch
from
9d0fc7d to
d9cb6e9
Compare
Ellerbach
approved these changes
Jan 5, 2024
Ellerbach
left a comment
Ellerbach
left a comment
Member
There was a problem hiding this comment.
A lot of work placed here and not easy to review! All up, it seems good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various updates to the Arduino Compiler:
Known issues:
Microsoft Reviewers: Open in CodeFlow