Skip to content

Added CM4 model check to IsPi4#2125

Merged
Ellerbach merged 1 commit into
dotnet:mainfrom
Daniel-Foley:daniel-foley/AddCM4Support
Aug 30, 2023
Merged

Added CM4 model check to IsPi4#2125
Ellerbach merged 1 commit into
dotnet:mainfrom
Daniel-Foley:daniel-foley/AddCM4Support

Conversation

@Daniel-Foley

@Daniel-Foley Daniel-Foley commented Aug 29, 2023

Copy link
Copy Markdown
Contributor

Fixes #2126
Compute Module 4 needs to be handled the same way as a pi4. Right now, due to the device model of a CM4 being "Raspberry Pi Compute Module 4" it is being treated as a pi3(only in code that uses the IsPi4 bool). This causes a problem with the pin mapping and prevents the CM4 from having it's input/output and pullup/pulldown changed on OpenPin().

Microsoft Reviewers: Open in CodeFlow

CM4 needs to be handled the same way as a pi4. Right now, due to the device model of a CM4 being "Raspberry Pi Computer Module 4" it is being treated as a pi3. This causes a problem with the pin mapping and prevents the CM4 from having it's input/output and pullup/pulldown changed on OpenPin().
@ghost ghost added the area-System.Device.Gpio Contains types for using general-purpose I/O (GPIO) pins label Aug 29, 2023
@Daniel-Foley Daniel-Foley changed the title Added CM4 model check to IsPi4 Added CM4 model check to IsPi4 - fixes 2126 Aug 29, 2023
@Daniel-Foley Daniel-Foley changed the title Added CM4 model check to IsPi4 - fixes 2126 Added CM4 model check to IsPi4 Aug 29, 2023
@Daniel-Foley Daniel-Foley marked this pull request as ready for review August 29, 2023 13:59

@Ellerbach Ellerbach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Ellerbach

Copy link
Copy Markdown
Member

/azp run dotnet.iot

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@Ellerbach Ellerbach merged commit e73bcac into dotnet:main Aug 30, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Device.Gpio Contains types for using general-purpose I/O (GPIO) pins

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Raspberry Pi Compute Module 4 support not being detected as a Pi4.

3 participants