Refactor status handling in SHTC3 binding #2038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Reduce to a single Status property * Only check current status in WakeUp/Sleep methods, where it's needed * Add an "Unknown" status enum value to describe the moments before we have explictly set the status.
ghost
added
the
area-device-bindings
|
|
krwq
approved these changes
Feb 14, 2023
Ellerbach
approved these changes
Feb 15, 2023
Member
Ellerbach
left a comment
Ellerbach
left a comment
There was a problem hiding this comment.
Looks god to me. Thanks for the fix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on Discord with @krwq
_statusfield (use field instead of property, per feedback)Wakeup/Sleepmethods, where it's neededUnknownstatus enum value to describe the moments before we have explicitly set the status.Of course, fully tested on physical hardware.
Microsoft Reviewers: Open in CodeFlow