Enable the command history and token variables #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -148,7 +138,7 @@ public override bool TryGetVariable(string name, out object value) | |||
| return Task.CompletedTask; | |||
| } | |||
|
|
|||
| if (cancellationSource.IsCancellationRequested) | |||
| if (context.CancellationToken.IsCancellationRequested) | |||
There was a problem hiding this comment.
Does this get canceled when the user hits stop in the Jupyter GUI?
If so, I'd like to see this cancel the PowerShell execution if possible.
There was a problem hiding this comment.
@jonsequitur made the change to lift up the support to cancel an operation, but it's not entirely wired up yet (take a look at that property in KernelInvocationContext). I will submit a separate PR to cancel PowerShell execution when it's wired up.
jonsequitur
approved these changes
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #142
The PR contains 2 major changes:
CancellationTokenSourcedefined in the PowerShell kernel, and usecontext.CancellationTokeninstead.PSInvocationSettingswhen invoking PowerShell commands, so as to enable command history and token variables.