Skip to content

format string as text/plain by default #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 2, 2020
Merged

format string as text/plain by default #220

merged 2 commits into from
Mar 2, 2020

Conversation

jonsequitur
Copy link
Contributor

No description provided.

@daxian-dbw
Copy link
Contributor

This change will result in another conflict to #202, which I will resolve after this PR gets merged.

@jonsequitur
Copy link
Contributor Author

@daxian-dbw Does this imply a missing test case?

@daxian-dbw
Copy link
Contributor

daxian-dbw commented Mar 2, 2020 •
edited
Loading

@jonsequitur Not sure I understand what you mean. The conflict comes from changing of the test name as well as the input data (User: --> User: ) in that PR:
https://github.com/dotnet/interactive/pull/202/files#diff-c478be2c8789ea82ed8d3230293547beR310

@jonsequitur jonsequitur merged commit 8f46248 into dotnet:master Mar 2, 2020
@jonsequitur jonsequitur deleted the default-string-to-text-plain branch July 29, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

@colombod colombod colombod approved these changes

@TylerLeonhardt TylerLeonhardt TylerLeonhardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonsequitur @daxian-dbw @colombod @TylerLeonhardt