Skip to content

Additional information about shared frameworks to bundled versions #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 31, 2018

Conversation

dsplaisted
Copy link
Member

Adds known framework information for the base .NET Core shared framework, and adds information about runtime packs for shared frameworks. This information will be consumed by logic in dotnet/sdk#2774.

With this PR, the known framework information looks like this:

    <KnownFrameworkReference Include="Microsoft.NETCore.App"
                              TargetFramework="netcoreapp3.0"
                              RuntimeFrameworkName="Microsoft.NETCore.App"
                              DefaultRuntimeFrameworkVersion="3.0.0-preview-27218-01"
                              LatestRuntimeFrameworkVersion="3.0.0-preview-27218-01"
                              TargetingPackName="Microsoft.NETCore.App"
                              TargetingPackVersion="3.0.0-preview-27218-01"
                              AppHostPackNamePattern="runtime.**RID**.Microsoft.NETCore.DotNetAppHost"
                              AppHostRuntimeIdentifiers="freebsd-x64;linux-arm;linux-arm64;linux-musl-x64;linux-x64;osx-x64;rhel.6-x64;tizen.4.0.0-armel;tizen.5.0.0-armel;win-arm;win-arm64;win-x64;win-x86"
                              RuntimePackNamePatterns="runtime.**RID**.Microsoft.NETCore.App;runtime.**RID**.Microsoft.NETCore.DotNetHostResolver;runtime.**RID**.Microsoft.NETCore.DotNetHostPolicy"
                              RuntimePackRuntimeIdentifiers="freebsd-x64;linux-arm;linux-arm64;linux-musl-x64;linux-x64;osx-x64;rhel.6-x64;tizen.4.0.0-armel;tizen.5.0.0-armel;win-arm;win-arm64;win-x64;win-x86"
                              />
    
    <KnownFrameworkReference Include="Microsoft.WindowsDesktop.App"
                              TargetFramework="netcoreapp3.0"
                              RuntimeFrameworkName="Microsoft.WindowsDesktop.App"
                              DefaultRuntimeFrameworkVersion="3.0.0-alpha-27218-5"
                              LatestRuntimeFrameworkVersion="3.0.0-alpha-27218-5"
                              TargetingPackName="Microsoft.WindowsDesktop.App"
                              TargetingPackVersion="3.0.0-alpha-27218-5"
                              RuntimePackNamePatterns="runtime.**RID**.Microsoft.WindowsDesktop.App"
                              RuntimePackRuntimeIdentifiers="win-x64;win-x86"
                              />

    <KnownFrameworkReference Include="Microsoft.AspNetCore.App"
                              TargetFramework="netcoreapp3.0"
                              RuntimeFrameworkName="Microsoft.AspNetCore.App"
                              DefaultRuntimeFrameworkVersion="3.0.0-preview-18579-0056"
                              LatestRuntimeFrameworkVersion="3.0.0-preview-18579-0056"
                              TargetingPackName="Microsoft.AspNetCore.App"
                              TargetingPackVersion="3.0.0-preview-18579-0056"
                              RuntimePackNamePatterns="runtime.**RID**.Microsoft.AspNetCore.App"
                              RuntimePackRuntimeIdentifiers="win-x64;win-x86;win-arm;osx-x64;linux-musl-x64;linux-x64;linux-arm;linux-arm64"
                              />

The runtime identifiers for which runtime packs and apphost packs are available are generated by parsing the runtime.json from the corresponding NuGet package (e.g. Microsoft.NETCore.App). This may change as we evolve what targeting packs look like. @ericstj @natemcmaster

@dsplaisted dsplaisted requested review from livarcocc, nguerrera, peterhuene and a team December 31, 2018 02:35
@dsplaisted dsplaisted merged commit 8d071f3 into dotnet:master Dec 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants