Improve/fix cross-build support. #18658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make the TargetRid for non-portable cross-builds use the TargetArchitecture. - For source-build cross-builds default to portable. - Pass the TargetArchitecture to the installer repo.
|
@mmitche this overlaps with your current installer PR |
mmitche
reviewed
Feb 16, 2024
mmitche
reviewed
Feb 16, 2024
|
@mmitche is this good to merge? |
mmitche
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/source-build#3797.
@directhex @ViktorHofer @MichaelSimons ptal.
cc @Swapnali911 @omajid