Remove Arcade net9.0 workarounds #17987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelSimons
approved these changes
Dec 15, 2023
Member
Member
Author
|
The tools.sh override is still needed since not all repos have an updated Arcade which allows it to the framework version to be overridden. That means the corresponding issue will remain open until repos have got the new Arcade. |
am11
reviewed
Dec 15, 2023
src/SourceBuild/content/build.sh
Outdated
| # BuildXPlatTasks uses NetCurrent but that is not set since Arcade isn't used here. | ||
| # Bootstrap NetCurrent by deriving it from the installed .NET CLI version. | ||
| dotnetVersion=$(echo $("$CLI_ROOT/dotnet" --version) | sed -E 's/^([0-9]+\.[0-9]+)\..*/\1/') | ||
| netCurrent="net$dotnetVersion" |
Member
There was a problem hiding this comment.
nit: a bit light-weight variant:
netCurrent="$(dotnet --version | while IFS='.' read major minor _; do echo "net$major.$minor"; done)"
Member
Author
There was a problem hiding this comment.
Thanks! I like the readability of that.
ViktorHofer
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to dotnet/source-build#3743