Moved fsharpqa/Libraries/Core/Operators test cases to NUnit #9570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinRansom
approved these changes
Jun 26, 2020
Contributor
KevinRansom
left a comment
KevinRansom
left a comment
There was a problem hiding this comment.
Thank you so much for taking care of this.
Kevin
| let ``Sign of byte``() = | ||
| CompilerAssert.TypeCheckSingleError | ||
| """ | ||
| sign 0uy |> ignore |
Member
There was a problem hiding this comment.
Minor comment (more of a nitpick really):
I think, it's better to place all (new) tests which are using CompilerAssert to our new Compiler.ComponentTests project, since it's more of a "blackbox-style" testing of the compiler, as oppose to this suite, which (in my opinion) should contain smaller unit-style tests (such as tests Assert tests above, or string tests, etc).
vzarytovskii
approved these changes
Jun 26, 2020
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #7075.