Skip to content

[WIP] Improve error reporting: Missing = on type declaration #6603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

AndrewBoklashko
Copy link

@AndrewBoklashko AndrewBoklashko commented Apr 21, 2019

This is my attempt to implement #1121.
I've been digging into FsLex/FsYacc parsing rules and was able to find out the changes I need to make.
But after I've made them, the project just doesn't build anymore. Without changes introduced in this PR build works fine for me so it's most likely that my code is wrong.
Unfortunately I don't get any error messages and I can't figure out where is the problem by myself.
I would like someone to take a look at this PR and advise me what is the problem here.

VS 2019 developer cmd output:

C:\Projects\visualfsharp>build.cmd -c Debug
Building bootstrap compiler
dotnet-install: Downloading link: https://dotnetcli.azureedge.net/dotnet/Sdk/2.1.504/dotnet-sdk-2.1.504-win-x64.zip
dotnet-install: Extracting zip from https://dotnetcli.azureedge.net/dotnet/Sdk/2.1.504/dotnet-sdk-2.1.504-win-x64.zip
dotnet-install: Adding to current process PATH: "C:\Projects\visualfsharp\.dotnet\". Note: This change will not be visible if PowerShell was run as a child process.
dotnet-install: Installation finished
  Restore completed in 1.19 sec for C:\Projects\visualfsharp\src\buildtools\fslex\fslex.fsproj.
  Restore completed in 55.86 ms for C:\Projects\visualfsharp\src\buildtools\fsyacc\fsyacc.fsproj.
  fslex -> C:\Projects\visualfsharp\artifacts\bin\fslex\Proto\netcoreapp2.1\fslex.dll
  fsyacc -> C:\Projects\visualfsharp\artifacts\bin\fsyacc\Proto\netcoreapp2.1\fsyacc.dll

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:10.26
  Restore completed in 2.77 sec for C:\Projects\visualfsharp\src\fsharp\FSharp.Build\FSharp.Build.fsproj.
  Restore completed in 3.17 sec for C:\Projects\visualfsharp\src\fsharp\FSharp.Core\FSharp.Core.fsproj.
  Restore completed in 9.89 ms for C:\Projects\visualfsharp\src\fsharp\FSharp.Build\FSharp.Build.fsproj.
  Restore completed in 26.84 ms for C:\Projects\visualfsharp\src\fsharp\FSharp.Core\FSharp.Core.fsproj.
  Restore completed in 572.34 ms for C:\Projects\visualfsharp\src\fsharp\FSharp.Compiler.Private\FSharp.Compiler.Private
  .fsproj.
  Restore completed in 624.21 ms for C:\Projects\visualfsharp\src\fsharp\fsc\fsc.fsproj.
  Restore completed in 16.16 ms for C:\Projects\visualfsharp\src\fsharp\FSharp.Compiler.Private\FSharp.Compiler.Private.
  fsproj.
  Restore completed in 18.3 ms for C:\Projects\visualfsharp\src\fsharp\FSharp.Core\FSharp.Core.fsproj.
  Restore completed in 105 ms for C:\Projects\visualfsharp\src\fsharp\FSharp.Compiler.Server.Shared\FSharp.Compiler.Serv
  er.Shared.fsproj.
  Restore completed in 387.59 ms for C:\Projects\visualfsharp\src\fsharp\FSharp.Compiler.Interactive.Settings\FSharp.Com
  piler.Interactive.Settings.fsproj.
  Restore completed in 438.37 ms for C:\Projects\visualfsharp\src\fsharp\fsi\fsi.fsproj.
  FSharp.Core -> C:\Projects\visualfsharp\artifacts\bin\FSharp.Core\Proto\net45\FSharp.Core.dll
  FSharp.Build -> C:\Projects\visualfsharp\artifacts\bin\FSharp.Build\Proto\net472\FSharp.Build.dll
  FSharp.Compiler.Interactive.Settings -> C:\Projects\visualfsharp\artifacts\bin\FSharp.Compiler.Interactive.Settings\Pr
  oto\net472\FSharp.Compiler.Interactive.Settings.dll

Build FAILED.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:26.14
Command failed to execute with exit code 1: C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\\MSBuild\Current\Bin\MSBuild.exe  /p:TreatWarningsAsErrors=true /nologo /nodeReuse:false /p:Configuration=Proto  /warnaserror /consoleloggerparameters:Verbosity=minimal;summary /m /restore /t:Build C:\Projects\visualfsharp\proto.proj
System.Management.Automation.RuntimeException: Command failed to execute with exit code 1: C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\\MSBuild\Current\Bin\MSBuild.exe  /p:TreatWarningsAsErrors=true /nologo /nodeReuse:false /p:Configuration=Proto  /warnaserror /consoleloggerparameters:Verbosity=minimal;summary /m /restore /t:Build C:\Projects\visualfsharp\proto.proj
at Exec-CommandCore, C:\Projects\visualfsharp\eng\build-utils.ps1: line 50
at Exec-Console, C:\Projects\visualfsharp\eng\build-utils.ps1: line 119
at Run-MSBuild, C:\Projects\visualfsharp\eng\build-utils.ps1: line 228
at Make-BootstrapBuild, C:\Projects\visualfsharp\eng\build-utils.ps1: line 250
at <ScriptBlock>, C:\Projects\visualfsharp\eng\build.ps1: line 235
at <ScriptBlock>, <No file>: line 1

@msftclas
Copy link

msftclas commented Apr 21, 2019

CLA assistant check
All CLA requirements met.

@AndrewBoklashko
Copy link
Author

@cartermp hi!
Do you know anyone who can help me with the build problem?

@cartermp
Copy link
Contributor

@AndrewBoklashko What happens if you just use build? This is failing to build the proto compiler .proj project, so I don't think it's related to your change.

@AndrewBoklashko
Copy link
Author

@cartermp do you mean without -c Debug setting?
I get the same output if I just use build too.

@cartermp
Copy link
Contributor

@AndrewBoklashko Sorry for not getting back to you here. Are you still interested in pursuing this work? The codebase has diverged a lot, unfortunately. As for your question - I think there may have been something odd with the build on your machine. If you can try it against the latest master, that would give more a clue.

@cartermp
Copy link
Contributor

cartermp commented Jul 4, 2020

Closing out old PR. @AndrewBoklashko please ping if you'd like this re-opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants