Skip to content

[wip] Possible reversion of 3283 (Tuple<...> regression with Item* and Rest properties) #4029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dsyme
Copy link
Contributor

@dsyme dsyme commented Nov 28, 2017

It may be the best thing is to revert #3283 because of the gradual emergence of more serious cases of regressions in #3729

We should probably have a final think about this before doing it. The more expensive option mentioned in #3729 is possible, but takes significant dev and test time.

In particular his change in itself will break code that was written in the interim, including:

  1. code changed to account for Breaking change in tuples after VS 15.4 update #3729
  2. code using Tuple.Create and explicitly annotating with a return type of
  3. new code assuming a total equivalence between F#-authored declarations of Tuple<A,B> and A*B.

I've marked this as WIP since a reversion that breaks code makes me feel queasy.

@cartermp
Copy link
Contributor

I agree that this is a rather awkward position to be in, as it is unknown how much code has either:

But assuming that we do go this route, we should also have a quick test for the regression, which could then be updated when we complete the work to make them the same and allow for accessing those properties.

@dsyme
Copy link
Contributor Author

dsyme commented Nov 29, 2017

I'm closing this in favour of forward-moving resolution #4034. We can reopen if we decide to move backwards instead

@dsyme dsyme closed this Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants