Skip to content

restore coreclr.dll from a NuGet package instead of assuming its location #4005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 27, 2017
Merged

restore coreclr.dll from a NuGet package instead of assuming its location #4005

merged 1 commit into from
Nov 27, 2017

Conversation

brettfo
Copy link
Member

@brettfo brettfo commented Nov 23, 2017 •
edited
Loading

This should improve test stability for non-coreclr scenarios where that file won't necessarily be in the Tools directory.

@brettfo brettfo changed the title only try to copy coreclr.dll when ildasm is actually invoked restore coreclr.dll from a NuGet package instead of assuming its location Nov 27, 2017
@brettfo brettfo merged commit 62e9bdf into dotnet:master Nov 27, 2017
@brettfo brettfo deleted the ildasm-coreclr branch November 27, 2017 19:15
@cartermp cartermp mentioned this pull request Dec 5, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@brettfo