Skip to content

Restore XunitTestFramework#19356

Draft
Youssef1313 wants to merge 3 commits intodotnet:mainfrom
Youssef1313:dev/ygerges/exp
Draft

Restore XunitTestFramework#19356
Youssef1313 wants to merge 3 commits intodotnet:mainfrom
Youssef1313:dev/ygerges/exp

Conversation

@Youssef1313
Copy link
Member

Description

Fixes # (issue, if applicable)

Checklist

  • Test cases added

  • Performance benchmarks added in case of performance changes

  • Release notes entry updated:

    Please make sure to add an entry with short succinct description of the change as well as link to this pull request to the respective release notes file, if applicable.

    Release notes files:

    • If anything under src/Compiler has been changed, please make sure to make an entry in docs/release-notes/.FSharp.Compiler.Service/<version>.md, where <version> is usually "highest" one, e.g. 42.8.200
    • If language feature was added (i.e. LanguageFeatures.fsi was changed), please add it to docs/release-notes/.Language/preview.md
    • If a change to FSharp.Core was made, please make sure to edit docs/release-notes/.FSharp.Core/<version>.md where version is "highest" one, e.g. 8.0.200.

    Information about the release notes entries format can be found in the documentation.
    Example:

    If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

@github-actions
Copy link
Contributor

✅ No release notes required


// Because xUnit v2 lacks assembly fixture, this is a good place to ensure things get called right at the start of the test run.
override x.RunTestCases(testCases, executionMessageSink, executionOptions) =
// Because xUnit v3 lacks assembly fixture, this is a good place to ensure things get called right at the start of the test run.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v3 has assembly fixture, might be less hassle than reviving this monstrosity :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, I'll switch to using ITestPipelineStartup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: New

Development

Successfully merging this pull request may close these issues.

2 participants