Editor: Fix Record fields completion in update record with partial field name#18946
Editor: Fix Record fields completion in update record with partial field name#18946T-Gro merged 5 commits intodotnet:mainfrom
Conversation
❗ Release notes required
|
|
/backport to release/dev18.0 |
|
Started backporting to release/dev18.0: https://github.com/dotnet/fsharp/actions/runs/18136678632 |
|
I don't quite understand this. Both work for me in the latest VS 2026, and isn't |
| let isCaretAfterFieldNameWithoutValue = (e.IsNone && posEq pos field.Range.End) | ||
|
|
||
| if rangeContainsPos field.Range pos || isCaretAfterFieldNameWithoutValue then |
There was a problem hiding this comment.
I agree with @kerams here.
@edgarfgp Could you please explain what exactly does this change do?
rangeContainsPos field.Range pos includes the case when posEq pos field.Range.End is true.
How is it possible that the second part of the condition is ever true then?
And what does the checking the specific case of no expression add here? Especially in the branch that should never be true.
Description
Fix Record fields completion in update record with partial field name
Checklist