Fix dotnet build VisualFSharp.sln#18914
Merged
T-Gro merged 4 commits intodotnet:mainfrom Sep 18, 2025
Merged
Conversation
Contributor
|
Contributor
Author
|
I see it didn't work in general, this breaks another things (VSSDK1012: The cto merger could not read the data) Maybe copilot can make it conditional, but I doubt. |
Contributor
Author
Contributor
Author
|
Now, this is very incompatible with then this should work from Rider and from commandline as a bonus, now the |
T-Gro
approved these changes
Sep 18, 2025
Member
|
@majocha Thank you very much for investigating and fixing it! |
This was referenced Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Running
dotnet build VisualFSharp.slnfails with error:So let's set it to true and see it anything breaks.
Should fix #18886.