VS: initialize package in the background#18646
Conversation
❗ Release notes required
|
|
Works ok in experimental instance. It seems we don't need the UI thread during package init. |
|
Thanks for taking this up @majocha . Lets merge this in after it can be locally tested. |
vsintegration/src/FSharp.Editor/LanguageService/LanguageService.fs
Outdated
Show resolved
Hide resolved
6f1154d to
05822f0
Compare
8b8328d to
3772b2b
Compare
|
I included fix for #18904. The setting was never set because the |
|
I'm testing this PR atm. It seems fine now. FSI initializes ok. If there are any problems, (for example deadlocks at startup) it's a matter of moving some things from the background to foreground init. |
|
I am going to merge this as it fixes an important user-facing regression with the solution crawler. @majocha : You are our hero 👍 ! |
|
/backport to release/dev18.0 |
|
Started backporting to release/dev18.0: https://github.com/dotnet/fsharp/actions/runs/18745823459 |
|
@T-Gro backporting to "release/dev18.0" failed, the patch most likely resulted in conflicts: $ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: vs initialize in background
Using index info to reconstruct a base tree...
M vsintegration/src/FSharp.Editor/LanguageService/LanguageService.fs
Falling back to patching base and 3-way merge...
Auto-merging vsintegration/src/FSharp.Editor/LanguageService/LanguageService.fs
CONFLICT (content): Merge conflict in vsintegration/src/FSharp.Editor/LanguageService/LanguageService.fs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 vs initialize in background
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
Resolves #18623, fixes #18904