TestTP: Minor perf opt for ProvidedTypes.fs#18541
Merged
T-Gro merged 1 commit intodotnet:mainfrom May 22, 2025
Merged
Conversation
- isNull is inline also in FSharp.Core - Lazy load of ILAssemblyRefs - Avoid looping 120 libraries through on most cases
Contributor
✅ No release notes required |
KevinRansom
suggested changes
May 12, 2025
Contributor
KevinRansom
left a comment
There was a problem hiding this comment.
This file is a core part of the typeprovider SDK which is managed in: https://github.com/fsprojects/FSharp.TypeProviders.SDK
fsprojects/FSharp.TypeProviders.SDK#417
Is there some reason why it hasn't been merged there yet?
The file in this repo is a local fork. It would probably be best to make the change in it's real home, then port that file back to this repo, what do you think?
Contributor
Author
|
I would expect it not to be merged because Don has more important things to focus on. Yes, I agree it could make sense not to maintain 2 copies of the file. Normally, I'd add the file as a Paket file reference, but Paket is not used here. |
Contributor
Author
|
The PR in TP SDK side merged now. |
T-Gro
approved these changes
May 22, 2025
This was referenced Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I would love to have some benchmark tests for ProvidedTypes.fs but the issue is that it's mostly used by FSharp.Compiler via a heavy IDE, and current unit-tests are not covering the majority of the process, so I don't have any idea how that could be done. Right now the best way seems to be to attach a VS to VS and open some type-provider and see what is going on.