Allow let! and use! binding with type annotation without parentheses.#18508
Allow let! and use! binding with type annotation without parentheses.#18508T-Gro merged 38 commits intodotnet:mainfrom
let! and use! binding with type annotation without parentheses.#18508Conversation
❗ Release notes required
|
|
It might be interesting in a follow up PR to add error recovery for cases where we have a let! x:
use! stream:
let x:
use x:Where we can use |
baronfel
left a comment
There was a problem hiding this comment.
Love the depth of test coverage here.
T-Gro
left a comment
There was a problem hiding this comment.
This is really a nice addition @edgarfgp 👍 .
I think this is a change where we would be better with having a languageFeature guard with recovery.
Reason is, people might be having mismatched SDKs locally vs CI.
This change would allow code to pass locally, but then surprisingly fail parsing when ran on CI with a different SDK version.
LanguageVersion will cover for that scenario.
|
@T-Gro Updated as requested |
Description
Allow
let!anduse!binding with type annotation without parentheses.Fixes #10697
BEFORE
AFTER
Once #18487 is merged
Checklist