Consolidate SynExpr.LetOrUseBang(isUse=false)#18482
Merged
T-Gro merged 7 commits intodotnet:mainfrom Apr 25, 2025
Merged
Conversation
edgarfgp
added
the
NO_RELEASE_NOTES
edgarfgp
changed the title
SynExpr.LetOrUseBang(isUse=false)
Contributor
|
2 tasks
T-Gro
reviewed
Apr 24, 2025
Member
T-Gro
left a comment
T-Gro
left a comment
There was a problem hiding this comment.
Why is there suddenly code added?
I expected more code deletions to match it up here, what am I missing?
edgarfgp
force-pushed
the
more-ce-logic-deduplication
branch
from
9f5c4a3 to
41e7872
Compare
Contributor
Author
@T-Gro No you are right. I consolidated the two cases into one(active pattern). But I forgot to remove the duplicated code :). |
T-Gro
approved these changes
Apr 25, 2025
abonie
approved these changes
Apr 25, 2025
github-project-automation
bot
moved this from New
to In Progress
in F# Compiler and Tooling
github-project-automation
bot
moved this from In Progress
to Done
in F# Compiler and Tooling
This was referenced Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Continuation of #18472
Checklist