Skip to content

Fix GraphNode deadlock #18178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2025
Merged

Fix GraphNode deadlock #18178

merged 1 commit into from
Jan 2, 2025

Conversation

majocha
Copy link
Contributor

@majocha majocha commented Dec 28, 2024

Description

Fix the deadlock by replacing the continuation with a simple await. Also simplify the code a bit.

Fixes #18115

Checklist

  • Tested by running 1000 iterations locally but it should be apparent in the CI if the fix really works.
  • Performance should be unchanged or a bit better because of less indirect code.
  • Release notes entry updated

@majocha majocha requested a review from a team as a code owner December 28, 2024 10:26
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 28, 2024 •
edited
Loading

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@T-Gro T-Gro added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Jan 2, 2025
@T-Gro T-Gro merged commit b1659a1 into dotnet:main Jan 2, 2025
33 of 34 checks passed
This was referenced Jan 8, 2025
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T-Gro T-Gro T-Gro approved these changes

+1 more reviewer

@0101 0101 0101 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rare deadlock in GraphNode.GetOrComputeValue
3 participants
@majocha @0101 @T-Gro