Skip to content

Tests: fix setting the original shim in the FileSystem shim tests #18142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Tests: fix setting the original shim in the FileSystem shim tests #18142

wants to merge 1 commit into from

Conversation

auduchinok
Copy link
Member

Fixes the wrong logic in the Dispose implementation.

@auduchinok auduchinok requested a review from a team as a code owner December 13, 2024 18:11
@github-actions GitHub Actions
Copy link
Contributor

✅ No release notes required

psfinaki
psfinaki approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Eugene!

@psfinaki
Copy link
Member

Okay I see this was incorporated in the sibling PR, so closing this one :)

@psfinaki psfinaki closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psfinaki psfinaki psfinaki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@auduchinok @psfinaki