Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error reporting for use #17811

Merged
merged 16 commits into from
Oct 8, 2024

Conversation

edgarfgp
Copy link
Contributor

@edgarfgp edgarfgp commented Sep 27, 2024

Description

Better error reporting for use

Continuation of #17779

Before

Screenshot 2024-09-30 at 20 09 48

Screenshot 2024-09-30 at 20 10 12

After

let x11 = 
    query { for c in [1..10] do
            use x = { new System.IDisposable with __.Dispose() = () }
            ^^^
            yield 1  }
    
    
let run r2 r3 =
    result {
        use b = r2
        ^^^
        return Ok 0
    }

Checklist

  • Test cases added
  • Release notes entry updated

Copy link
Contributor

github-actions bot commented Sep 27, 2024

❗ Release notes required


✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.200.md

@edgarfgp edgarfgp force-pushed the better-error-reporing-for-ce-use branch from 7432bc0 to 10ef6cc Compare September 27, 2024 13:56
@edgarfgp edgarfgp force-pushed the better-error-reporing-for-ce-use branch from 0181359 to 162e1a0 Compare September 27, 2024 21:12
@edgarfgp edgarfgp force-pushed the better-error-reporing-for-ce-use branch 2 times, most recently from 2424b52 to 5860c33 Compare September 30, 2024 15:52
@edgarfgp edgarfgp force-pushed the better-error-reporing-for-ce-use branch from 5860c33 to 4ae2db0 Compare September 30, 2024 16:52
@edgarfgp edgarfgp marked this pull request as ready for review September 30, 2024 19:27
@edgarfgp edgarfgp requested a review from a team as a code owner September 30, 2024 19:27
@edgarfgp
Copy link
Contributor Author

This is ready

@edgarfgp edgarfgp requested review from T-Gro and abonie October 1, 2024 18:47
@vzarytovskii vzarytovskii enabled auto-merge (squash) October 3, 2024 20:36
@edgarfgp
Copy link
Contributor Author

edgarfgp commented Oct 4, 2024

Can I have a second review please ?

@edgarfgp edgarfgp closed this Oct 4, 2024
auto-merge was automatically disabled October 4, 2024 16:55

Pull request was closed

@edgarfgp edgarfgp reopened this Oct 4, 2024
# Conflicts:
#	tests/FSharp.Compiler.ComponentTests/Language/ComputationExpressionTests.fs
@edgarfgp
Copy link
Contributor Author

edgarfgp commented Oct 8, 2024

Fixed merge conflicts and it is green again.

@vzarytovskii vzarytovskii merged commit 69cc8a4 into dotnet:main Oct 8, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants