-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better error reporting for use
#17811
Merged
vzarytovskii
merged 16 commits into
dotnet:main
from
edgarfgp:better-error-reporing-for-ce-use
Oct 8, 2024
Merged
Better error reporting for use
#17811
vzarytovskii
merged 16 commits into
dotnet:main
from
edgarfgp:better-error-reporing-for-ce-use
Oct 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❗ Release notes required
|
edgarfgp
force-pushed
the
better-error-reporing-for-ce-use
branch
from
September 27, 2024 13:56
7432bc0
to
10ef6cc
Compare
edgarfgp
force-pushed
the
better-error-reporing-for-ce-use
branch
from
September 27, 2024 21:12
0181359
to
162e1a0
Compare
…p/fsharp into better-error-reporing-for-ce-use
edgarfgp
force-pushed
the
better-error-reporing-for-ce-use
branch
2 times, most recently
from
September 30, 2024 15:52
2424b52
to
5860c33
Compare
edgarfgp
force-pushed
the
better-error-reporing-for-ce-use
branch
from
September 30, 2024 16:52
5860c33
to
4ae2db0
Compare
This is ready |
vzarytovskii
approved these changes
Oct 3, 2024
Can I have a second review please ? |
auto-merge was automatically disabled
October 4, 2024 16:55
Pull request was closed
# Conflicts: # tests/FSharp.Compiler.ComponentTests/Language/ComputationExpressionTests.fs
Fixed merge conflicts and it is green again. |
This was referenced Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Better error reporting for
use
Continuation of #17779
Before
After
Checklist