Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error reporting for CE match! #17789

Merged
merged 5 commits into from
Sep 26, 2024
Merged

Better error reporting for CE match! #17789

merged 5 commits into from
Sep 26, 2024

Conversation

edgarfgp
Copy link
Contributor

@edgarfgp edgarfgp commented Sep 25, 2024 •
edited
Loading

Description

Better error reporting for CE match!

Continuation of #17779

Before

Screenshot 2024-09-25 at 13 59 23

After

let run r2 r3 =
    match! r2 with
    ^^^^^^
    | Ok x -> x
    | Error e -> e

Checklist

  • Test cases added
  • Release notes entry updated

@edgarfgp edgarfgp requested a review from a team as a code owner September 25, 2024 15:07
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 25, 2024 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.200.md

@edgarfgp
Copy link
Contributor Author

This is ready

psfinaki
psfinaki approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I basically reviewed this in the previous PR :) Thanks Edgar, thanks for covering match! with some tests.

@edgarfgp edgarfgp closed this Sep 26, 2024
@edgarfgp edgarfgp reopened this Sep 26, 2024
@vzarytovskii vzarytovskii merged commit 36b3ba5 into dotnet:main Sep 26, 2024
32 checks passed
esbenbjerre pushed a commit to esbenbjerre/fsharp that referenced this pull request Sep 30, 2024
@edgarfgp @esbenbjerre
Better error reporting for CE match! (dotnet#17789)
922f4bd 
* Better error reporting for `CE`  `match!`

* release notes
This was referenced Oct 31, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psfinaki psfinaki psfinaki approved these changes

@vzarytovskii vzarytovskii vzarytovskii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edgarfgp @vzarytovskii @psfinaki