Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing Nunit from utils #17770

Merged
merged 20 commits into from
Sep 24, 2024
Merged

Removing Nunit from utils #17770

merged 20 commits into from
Sep 24, 2024

Conversation

psfinaki
Copy link
Member

@psfinaki psfinaki commented Sep 20, 2024 •
edited
Loading

Related: #13654

TL;DR: We are nearly done!

  • This removes Nunit from test frameworks
  • Cleans things up
  • Enables 32 valid ComponentTests that were silently not being executed

Please see my comments everywhere, this is close to the equivalent code, with minor simplifications and fixes.

Note this increases the number of tests executed in the CI. The execution time is not affected.

Main:
image

This branch:
image

This is due to:

  • 5 new tests in the FSharpSuite. Those are old-new AsyncTests and they are skipped anyway for now. See comment.
  • 35 new tests in the ComponentTests.TypeChecks. Of those:
    • 2 CompilationFromCmdlineArgsTests and 1 TypedTreeGraphTests - those were explicit + failing, now skipped
    • 1 DependencyResolutionTests - this is legit and passing, wasn't being executed as [<Theory>] was forgotten there
    • 8 FileContentMappingTests, 1 GraphProcessingTests, 4 QueryTrieTests, 18 TrieMappingTests - those are legit and passing, weren't being executed because weren't rewritten to Xunit (so trying executing non-existing Nunit adapter)

@github-actions GitHub Actions
Copy link
Contributor

✅ No release notes required

@psfinaki psfinaki marked this pull request as ready for review September 24, 2024 11:15
@psfinaki psfinaki requested a review from a team as a code owner September 24, 2024 11:15
@psfinaki psfinaki merged commit cd736c4 into dotnet:main Sep 24, 2024
32 checks passed
esbenbjerre pushed a commit to esbenbjerre/fsharp that referenced this pull request Sep 30, 2024
@psfinaki @KevinRansom @esbenbjerre
Removing Nunit from utils (dotnet#17770)
b819d6d 
* Migrate last Nunit tests to Xunit

* up

* up

* up

* Update TestLib.LanguageService.fs

* up

* up

* up

* Remove unused tests

* one more

* Salsa

* up

* up

* up

* Update FsUnit.fs

* Up

* Update AsyncTests.fs

---------

Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com>
This was referenced Oct 31, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T-Gro T-Gro T-Gro approved these changes

@abonie abonie abonie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@psfinaki @abonie @T-Gro @KevinRansom