Removing Nunit from utils #17770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

psfinaki merged 20 commits into dotnet:main from psfinaki:tests-11

Sep 24, 2024

Contributor

psfinaki commented Sep 20, 2024 •

edited

Loading

Related: #13654

TL;DR: We are nearly done!

This removes Nunit from test frameworks
Cleans things up
Enables 32 valid ComponentTests that were silently not being executed

Please see my comments everywhere, this is close to the equivalent code, with minor simplifications and fixes.

Note this increases the number of tests executed in the CI. The execution time is not affected.

Main:

This branch:

This is due to:

5 new tests in the FSharpSuite. Those are old-new AsyncTests and they are skipped anyway for now. See comment.
35 new tests in the ComponentTests.TypeChecks. Of those:
- 2 CompilationFromCmdlineArgsTests and 1 TypedTreeGraphTests - those were explicit + failing, now skipped
- 1 DependencyResolutionTests - this is legit and passing, wasn't being executed as [<Theory>] was forgotten there
- 8 FileContentMappingTests, 1 GraphProcessingTests, 4 QueryTrieTests, 18 TrieMappingTests - those are legit and passing, weren't being executed because weren't rewritten to Xunit (so trying executing non-existing Nunit adapter)

psfinaki and others added 17 commits

September 16, 2024 19:24


          Migrate last Nunit tests to Xunit

533511d

up

d22973d

up

ff9ba24

up

c3114cb


          Update TestLib.LanguageService.fs

03ac691

up

715ff7c

up

ba5108b


          Merge branch 'main' into tests-10

a70d897

up

ac7b0fb


          Remove unused tests

1e4d34a


          one more

49ed74b


          Salsa

fb1d19d

up

5aec65f

up

b57cb28


          Merge branch 'tests-10' into tests-11

d46483e

up


          Update FsUnit.fs

1fbeef2

Contributor

github-actions bot commented Sep 20, 2024

✅ No release notes required

psfinaki added 3 commits

September 20, 2024 17:54

Up

049e946


          Update AsyncTests.fs

01e2eff


          Merge branch 'main' into tests-11

85617ce

psfinaki commented

View reviewed changes

tests/FSharp.Compiler.ComponentTests/TypeChecks/Graph/CompilationFromCmdlineArgsTests.fs Show resolved Hide resolved

psfinaki commented

View reviewed changes

tests/FSharp.Compiler.ComponentTests/TypeChecks/Graph/CompilationFromCmdlineArgsTests.fs Show resolved Hide resolved

psfinaki commented

View reviewed changes

tests/FSharp.Compiler.ComponentTests/TypeChecks/Graph/DependencyResolutionTests.fs Show resolved Hide resolved

psfinaki commented

View reviewed changes

tests/FSharp.Compiler.ComponentTests/TypeChecks/Graph/DependencyResolutionTests.fs Show resolved Hide resolved

psfinaki commented

View reviewed changes

tests/FSharp.Compiler.ComponentTests/TypeChecks/Graph/FileContentMappingTests.fs Show resolved Hide resolved

psfinaki commented

View reviewed changes

tests/FSharp.Compiler.ComponentTests/TypeChecks/Graph/TrieMappingTests.fs Show resolved Hide resolved

psfinaki commented

View reviewed changes

tests/FSharp.Compiler.ComponentTests/TypeChecks/Graph/TypedTreeGraph.fs Show resolved Hide resolved

psfinaki commented

View reviewed changes

tests/FSharp.Core.UnitTests/FSharp.Core/Microsoft.FSharp.Core/IntConversionsTestGenerator.fsx Show resolved Hide resolved

psfinaki commented

View reviewed changes

tests/FSharp.Test.Utilities/Compiler.fs Show resolved Hide resolved

psfinaki commented

View reviewed changes

tests/FSharp.Test.Utilities/CompilerAssert.fs Show resolved Hide resolved

psfinaki commented

View reviewed changes

tests/fsharp/Compiler/Libraries/Core/Async/AsyncTests.fs Show resolved Hide resolved

psfinaki commented

View reviewed changes

tests/fsharp/FSharpSuite.Tests.fsproj Show resolved Hide resolved

psfinaki commented

View reviewed changes

tests/fsharp/nunitConf.fs Show resolved Hide resolved

psfinaki commented

View reviewed changes

tests/service/FsUnit.fs Show resolved Hide resolved

psfinaki commented

View reviewed changes

tests/service/FsUnit.fs Show resolved Hide resolved

psfinaki commented

View reviewed changes

tests/FSharp.Compiler.ComponentTests/TypeChecks/Graph/DependencyResolutionTests.fs Show resolved Hide resolved

psfinaki commented

View reviewed changes

tests/FSharp.Compiler.ComponentTests/TypeChecks/Graph/FileContentMappingTests.fs Show resolved Hide resolved

psfinaki commented

View reviewed changes

tests/FSharp.Compiler.ComponentTests/TypeChecks/Graph/GraphProcessingTests.fs Show resolved Hide resolved

psfinaki commented

View reviewed changes

tests/FSharp.Compiler.ComponentTests/TypeChecks/Graph/QueryTrieTests.fs Show resolved Hide resolved

psfinaki commented

View reviewed changes

tests/FSharp.Compiler.ComponentTests/TypeChecks/Graph/TrieMappingTests.fs Show resolved Hide resolved

psfinaki marked this pull request as ready for review

September 24, 2024 11:15

psfinaki requested a review from a team as a code owner

September 24, 2024 11:15

T-Gro approved these changes

View reviewed changes

abonie approved these changes

View reviewed changes

psfinaki merged commit cd736c4 into dotnet:main

32 checks passed

This was referenced Oct 31, 2024

[Automated] PRs inserted in VS build main-35430.72 #17943

Closed

[Automated] PRs inserted in VS build feature.debugger.main-35430.275 #17944

Closed

dotnet-bot mentioned this pull request

[Automated] PRs inserted in VS build feature.debugger.shadowDebug-35518.109 #18027

Closed

psfinaki deleted the tests-11 branch

February 10, 2025 15:16

This was referenced Sep 8, 2025

Bump FSharp.Core from 8.0.100 to 9.0.303 NicoVIII/RunHelpers#22

Open

Bump FSharp.Core from 8.0.100 to 9.0.303 NicoVIII/SimpleOptics#10

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet