Disable UpdateXlfOnBuild for VMR builds

[T-Gro]

This changes the condition set for UpdateXlfOnBuild.

Right now, net9 builds are occasionally failing with "The target "UpdateXlf" does not exist in the project".

However, updating localization files happens locally before contribution (see guidelines), it is not needed as a CI step.

[github-actions]

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

[vzarytovskii]

I will be more interested in why are they failing.

[T-Gro]

I will be more interested in why are they failing.

The target is not correctly imported in case of net9, it is an issue within the UpdateXlf task.
Alex will follow on that.

[akoeplinger]

Looks like the xlf files need to be updated now since CI is no longer inadvertently regenerating them.

You can also remove the SKIP_NETCURRENT_FSC_BUILD workaround from

fsharp/src/Compiler/FSharp.Compiler.Service.fsproj

Lines 22 to 24 in 6a9747e

	On CI, OSX has problems with Xliff targets for net9, skipping via SKIP_NETCURRENT_FSC_BUILD until resolved ( The target "UpdateXlf" does not exist in the project.)
	-->
	<TargetFrameworks Condition=" '$(OfficialBuildId)' == '' AND '$(FSharpNetCoreProductDefaultTargetFramework)' != '' AND '$(Configuration)' != 'Proto' AND '$(SKIP_NETCURRENT_FSC_BUILD)' != 'true' ">$(FSharpNetCoreProductDefaultTargetFramework);$(TargetFrameworks)</TargetFrameworks>

[T-Gro]

Looks like the xlf files need to be updated now since CI is no longer inadvertently regenerating them.

You can also remove the SKIP_NETCURRENT_FSC_BUILD workaround from

fsharp/src/Compiler/FSharp.Compiler.Service.fsproj

Lines 22 to 24 in 6a9747e

	On CI, OSX has problems with Xliff targets for net9, skipping via SKIP_NETCURRENT_FSC_BUILD until resolved ( The target "UpdateXlf" does not exist in the project.)
	-->
	<TargetFrameworks Condition=" '$(OfficialBuildId)' == '' AND '$(FSharpNetCoreProductDefaultTargetFramework)' != '' AND '$(Configuration)' != 'Proto' AND '$(SKIP_NETCURRENT_FSC_BUILD)' != 'true' ">$(FSharpNetCoreProductDefaultTargetFramework);$(TargetFrameworks)</TargetFrameworks>

I can remove the workaround for CI steps, I have to keep the option to disable it for local MacOs/Linux contributors.
@vzarytovskii experienced the error when building on MacOs locally as well IIRC.

[psfinaki]

Hope it helps, thanks!

[akoeplinger]

I can remove the workaround for CI steps, I have to keep the option to disable it for local MacOs/Linux contributors.
@vzarytovskii experienced the error when building on MacOs locally as well IIRC.

Thanks, @ViktorHofer was also able to reproduce the issue locally and is looking into it. It currently looks like it is somehow related to project.assets.json being used from the Proto Configuration and that one doesn't contain net9.0

[ViktorHofer]

Yes. I would recommend to hold off on this change. I will look at it more tomorrow in #17588

[akoeplinger]

This is a good change regardless since we shouldn't be setting UpdateXlfOnBuild=true in CI builds.

[ViktorHofer]

Isn't the Arcade default sufficient? I don't recall other repos setting this.

[akoeplinger]

Yes the default should work too.

[T-Gro]

Ok, will see if the default works as well here.