Account for AllowNullLiteralAttribute when checking attribute targets
#17583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarfgp
changed the title
AllowNullLiteralAttribute when checking attribute targets
Contributor
|
edgarfgp
added
the
NO_RELEASE_NOTES
…:edgarfgp/fsharp into account-for-allow-null-literal-attribute # Conflicts: # tests/FSharp.Compiler.ComponentTests/Conformance/BasicGrammarElements/CustomAttributes/AttributeUsage/AttributeUsage.fs
…:edgarfgp/fsharp into account-for-allow-null-literal-attribute
T-Gro
approved these changes
Aug 23, 2024
psfinaki
approved these changes
Aug 23, 2024
Contributor
psfinaki
left a comment
psfinaki
left a comment
There was a problem hiding this comment.
Great job, thanks for improving nullness!
This was referenced Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AllowNullLiteralAttributehas a special treatment:FS935 Types with the 'AllowNullLiteral' attribute may only inherit from or implement types which also allow the use of the null literalFS934 Records, union, abbreviations and struct types cannot have the 'AllowNullLiteral' attributeSo we want to keep these special treatment for records and avoid having two errors for the same attribute.
Checklist