Account for CLIMutableAttribute when checking attribute targets#17559
Merged
T-Gro merged 4 commits intodotnet:mainfrom Aug 19, 2024
edgarfgp:cli-mutable-attributes-tests
Merged
Account for CLIMutableAttribute when checking attribute targets#17559T-Gro merged 4 commits intodotnet:mainfrom edgarfgp:cli-mutable-attributes-tests
CLIMutableAttribute when checking attribute targets#17559T-Gro merged 4 commits intodotnet:mainfrom
edgarfgp:cli-mutable-attributes-tests
Conversation
edgarfgp
changed the title
CLIMutableAttribute when checking attribute targets
edgarfgp
added
the
NO_RELEASE_NOTES
Contributor
|
Contributor
|
There are other cases where the attribute change has doubled up on error messages. We should probably spend the effort to go through the attribute errors and see where else we can reduce doubled up errors. |
T-Gro
approved these changes
Aug 19, 2024
This was referenced Aug 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CLIMutableAttributehas a special treatment(specific error FS3132) in the case of records(Only record types may have this attribute.)So we want to keep these special treatment for records and avoid having two errors for the same attribute.
Checklist