Create UseLocalCompiler.Directory.Build.props #17396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added props file, which will point to locally build compiler (Debug configuration), which can simply be included in contributor's project (via ` <Import Project="UseLocalCompiler.Directory.Build.props"/>`) to test changes.
|
Caution Repository is on lockdown for maintenance, all merges are on hold. |
✅ No release notes required |
T-Gro
reviewed
Jul 9, 2024
Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com>
T-Gro
reviewed
Jul 9, 2024
Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com>
T-Gro
reviewed
Jul 9, 2024
T-Gro
reviewed
Jul 9, 2024
Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com>
|
This should be somehow mentioned in the docs, and also explained how's this better than or different from this tip: https://github.com/dotnet/fsharp/blob/main/DEVGUIDE.md#using-your-custom-compiler-to-build-other-projects |
Sure, feel free to add it |
edgarfgp
approved these changes
Jul 9, 2024
T-Gro
approved these changes
Jul 12, 2024
|
Gonna merge it as is and add docs if needed |
|
Thanks |
This was referenced Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added props file, which will point to locally build compiler (Debug configuration), which can simply be included in contributor's project (via
<Import Project="UseLocalCompiler.Directory.Build.props"/>) to test changes easier.