Allow object expression without overrides#17387
Merged
vzarytovskii merged 30 commits intodotnet:mainfrom Aug 20, 2024
edgarfgp:allow-object-expression-without-overrides
Merged
Allow object expression without overrides#17387vzarytovskii merged 30 commits intodotnet:mainfrom edgarfgp:allow-object-expression-without-overrides
vzarytovskii merged 30 commits intodotnet:mainfrom
edgarfgp:allow-object-expression-without-overrides
Conversation
Contributor
❗ Release notes required
|
2 tasks
…m:edgarfgp/fsharp into allow-object-expression-without-overrides
1 task
Member
|
Can be merged after RFC is approved by Don |
psfinaki
reviewed
Aug 19, 2024
...Sharp.Compiler.ComponentTests/Conformance/Expressions/ObjectExpressions/ObjectExpressions.fs
Outdated
Show resolved
Hide resolved
…m:edgarfgp/fsharp into allow-object-expression-without-overrides
psfinaki
approved these changes
Aug 19, 2024
Contributor
psfinaki
left a comment
There was a problem hiding this comment.
Fabulous work. Thanks for adding tests for the old versions as well. Great stuff Edgar!
vzarytovskii
approved these changes
Aug 20, 2024
This was referenced Aug 28, 2024
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for object expression without overrides.
Before
To create an object expression without overrides, the user has to override a member, even if it is not necessary.
After
We won't need to use any workaround to use classes(abstract or non-abstract) in object expressions.
Checklist