-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow object expression without overrides #17387
Merged
vzarytovskii
merged 30 commits into
dotnet:main
from
edgarfgp:allow-object-expression-without-overrides
Aug 20, 2024
Merged
Allow object expression without overrides #17387
vzarytovskii
merged 30 commits into
dotnet:main
from
edgarfgp:allow-object-expression-without-overrides
Aug 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❗ Release notes required
|
edgarfgp
force-pushed
the
allow-object-expression-without-overrides
branch
from
July 6, 2024 21:41
e81303d
to
d08f0bb
Compare
2 tasks
edgarfgp
force-pushed
the
allow-object-expression-without-overrides
branch
from
July 29, 2024 19:00
d08f0bb
to
860efd1
Compare
edgarfgp
changed the title
Allow object expression without overrides
Allow object expression without overrides when base class has protected constructor
Jul 30, 2024
edgarfgp
force-pushed
the
allow-object-expression-without-overrides
branch
from
July 30, 2024 14:59
4446b57
to
1251e35
Compare
edgarfgp
force-pushed
the
allow-object-expression-without-overrides
branch
from
August 7, 2024 16:40
743d695
to
d8e0332
Compare
edgarfgp
force-pushed
the
allow-object-expression-without-overrides
branch
from
August 13, 2024 15:36
a78ad9b
to
4a26619
Compare
edgarfgp
force-pushed
the
allow-object-expression-without-overrides
branch
from
August 14, 2024 08:02
513f2ff
to
2233c5f
Compare
…m:edgarfgp/fsharp into allow-object-expression-without-overrides
1 task
edgarfgp
changed the title
Allow object expression without overrides when base class has protected constructor
Allow object expression without overrides
Aug 15, 2024
Can be merged after RFC is approved by Don |
psfinaki
reviewed
Aug 19, 2024
...Sharp.Compiler.ComponentTests/Conformance/Expressions/ObjectExpressions/ObjectExpressions.fs
Outdated
Show resolved
Hide resolved
…m:edgarfgp/fsharp into allow-object-expression-without-overrides
psfinaki
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fabulous work. Thanks for adding tests for the old versions as well. Great stuff Edgar!
vzarytovskii
approved these changes
Aug 20, 2024
This was referenced Aug 28, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for object expression without overrides.
Before
To create an object expression without overrides, the user has to override a member, even if it is not necessary.
After
We won't need to use any workaround to use classes(abstract or non-abstract) in object expressions.
Checklist