Skip to content

Fix issues for plain 'dotnet build Fsharp.Compiler.Service.sln` #17185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 21, 2024
Merged

Fix issues for plain 'dotnet build Fsharp.Compiler.Service.sln` #17185

merged 3 commits into from
May 21, 2024

Conversation

T-Gro
Copy link
Member

@T-Gro T-Gro commented May 20, 2024

Fix warnings+errors for plain dotnet build

@T-Gro T-Gro requested a review from a team as a code owner May 20, 2024 13:52
vzarytovskii
vzarytovskii reviewed May 20, 2024
View reviewed changes
vzarytovskii
vzarytovskii reviewed May 20, 2024
View reviewed changes
@T-Gro T-Gro merged commit 13e50b4 into feature/nullness May 21, 2024
@T-Gro T-Gro deleted the feature-nullness-fix-plain-builds branch May 21, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vzarytovskii vzarytovskii vzarytovskii left review comments

+1 more reviewer

@KevinRansom KevinRansom KevinRansom approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@T-Gro @vzarytovskii @KevinRansom