root -embed: files #17068
Merged
root -embed: files #17068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❗ Release notes required
|
abonie
approved these changes
Apr 19, 2024
T-Gro
approved these changes
Apr 19, 2024
|
For what it's worth, I wrote https://github.com/Smaug123/dotnet-pdb-analysis for pretty much exactly this purpose. |
We should probably integrate it into the test framework somehow, but ... priorities ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #16768 - Files passed with -embed:relative/path/to/file are not embedded.
This fixes the F# opens reader to correctly root -embed sourcefiles using same algorithm as is used for compile files.
I have manually verified it works, but we don't have a particularly good mechanism to verify pdb files contain the neccessary information.